Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Directive location: schema definition #382

Merged
merged 1 commit into from
May 6, 2016
Merged

Conversation

leebyron
Copy link
Contributor

@leebyron leebyron commented May 6, 2016

This allows directives to be defined on schema definitions.

As suggested by @helfer in #376.

This allows directives to be defined on schema definitions.
@ghost ghost added the CLA Signed label May 6, 2016
@coveralls
Copy link

coveralls commented May 6, 2016

Coverage Status

Coverage increased (+0.0005%) to 98.237% when pulling 664ea8b on directive-on-schema into 1b6824b on master.

@leebyron leebyron merged commit 0aa78f6 into master May 6, 2016
@leebyron leebyron deleted the directive-on-schema branch May 6, 2016 23:05
sogko added a commit to sogko/graphql-js that referenced this pull request Jun 1, 2016
* master: (26 commits)
  0.6.0
  Validation: improving overlapping fields quality (graphql#386)
  Validation: context.getFragmentSpreads now accepts selectionSet rather than fragment AST node
  Factor out more closure functions
  Factor out closure functions to normal functions
  Deprecated directive (graphql#384)
  RFC: Directive location: schema definition (graphql#382)
  RFC: Schema Language Directives (graphql#376)
  Export introspection in public API
  Export directive definitions. (graphql#381)
  BUG: Ensure building AST schema does not exclude @Skip and @include (graphql#380)
  documentation of schema constructor
  Revert "Remove all 'instanceof GraphQLSchema' checks" (graphql#377)
  remove all 'instanceof GraphQLSchema' checks (graphql#371)
  Error logging for new interface type semantics (graphql#350)
  Nit: Missing case in grammar for TypeSystemDefinition in comment
  Bug: printer can print non-parsable value
  Factor out suggestion quoting utility
  Minor refactoring
  Minor refactoring of error messages for unknown fields
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants