Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: uncomment package-lock.json check for unmet dependencies #3851

Closed
wants to merge 1 commit into from

Conversation

IvanGoncharov
Copy link
Member

Context: it was disabled due to bug in docusaurus plugin which was fixed a long time ago.

Context: As disscussed in graphql#3849 ESLint team is planning to deprecate the current config format and switch to:
https://eslint.org/docs/latest/use/configure/configuration-files-new
But it requires that all plugins that we use to support this format.

In my PoC attempt to use this new format biggest change is comming from converting YAML file into JS, so I decided to extract it into separate commit.
Note: beyound JS convertion I did a purely stylistic cleanup of `TODO` comments, beyound that this commit is pure convertion of YAML into JS.
@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 72fad87
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/63f00890b7d3a200085321aa
😎 Deploy Preview https://deploy-preview-3851--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@IvanGoncharov
Copy link
Member Author

Closed since I forget to rebase after #3851.

@IvanGoncharov IvanGoncharov deleted the pr_branch branch February 17, 2023 23:11
@IvanGoncharov IvanGoncharov restored the pr_branch branch February 17, 2023 23:11
@IvanGoncharov IvanGoncharov deleted the pr_branch branch February 22, 2023 20:38
@MamiStyle MamiStyle linked an issue Mar 26, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No entiendo nada
1 participant