Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Nested List Input Coercion not matching GraphQL spec #3859

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

BugFix: Nested List Input Coercion not matching GraphQL spec #3859

wants to merge 2 commits into from

Conversation

abhinand-c
Copy link

This PR fixes the issue mentioned in #3858 to align input coercion of nested list with the GraphQL spec.

Changes (Similar to graphql-python/graphql-core#194)

  • Adds check to validate and raises error for the condition
  • Updated tests to reflect the new logic, and validate error

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 3, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Mar 3, 2023 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 2cd4878
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/64023e42f64f180008831382
😎 Deploy Preview https://deploy-preview-3859--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@abhinand-c
Copy link
Author

Hi @Cito @IvanGoncharov
I hope everything's alright here. Is there anything more to do? And could you please review this PR?

@Cito Cito self-requested a review March 6, 2023 13:58
@yaacovCR
Copy link
Contributor

yaacovCR commented Mar 7, 2023

Hi, see #3858 (comment)

TLDR I think a helpful next step might be to bring the underlying issue to the attention of the WG at the next meeting.

@MamiStyle MamiStyle linked an issue Mar 26, 2023 that may be closed by this pull request
No entiendo nada #3866
Closed
@yaacovCR yaacovCR mentioned this pull request Nov 9, 2023
Merged
@yaacovCR yaacovCR mentioned this pull request Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cito Cito Awaiting requested review from Cito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No entiendo nada
2 participants
@abhinand-c @yaacovCR