-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbortController support #4250
AbortController support #4250
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
26bcf69
to
ae8f4fe
Compare
3a61463
to
f49401d
Compare
d51d39f
to
ae108b2
Compare
In |
451d412
to
ae108b2
Compare
3841aad
to
370d0f1
Compare
Co-Authored-By: yaacovCR <yaacovCR@gmail.com>
This adds support for aborting execution from the outside or resolvers, this adds a few tests and tries to make the support as easy as possible.
Do we want to support having abort support on subscriptions, I guess it makes sense for server-sent events.
I've chosen 2 places to place these interrupts
executeFieldsSerially
- every time we start a new mutation we check whether the runtime has interruptedexecuteFields
- every time we start executing a new field we check whether the runtime has interruptedWhen comparing this to
graphql-tools/execute
I am not sure whether we want to match this behavior, this throws a DomException which would be a whole new exception that gets thrown while normally during execution we wrap everything with GraphQLErrors.Supersedes #3791
Resolves #3764