-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
History persistence seems to be broken since v1.3.5 #312
Comments
It seems to work here https://www.graphqlbin.com/Agjcr I'm unsure if this is version 1.3.5 though. @timsuchanek we should add the version number in the UI somewhere :-) |
@sorenbs Thanks. Could you try and build a quick project off graphql-yoga? PS: yes, the version number in the UI is a very good idea. |
Thanks @morajabi. Btw @sorenbs @timsuchanek, I'll update the description with a clearer description. |
The only place in the codebase where I can see Going by the codebase, I understood that Thoughts? |
This is the commit that introduced that change: a43266e - It doesn't seem like something that was actually meant? I can't see the relation with the rest of the change in that commit. |
@sorenbs @timsuchanek Any feedback on whether or not my findings are actually relevant to the issue at hand? |
@kbrandwijk Maybe you have an opinion about this one? I am trying to restore this functionality. |
Anyone looking at this or #317? |
This should be fixed in |
This issue pertains to:
Don't have much time to write right now, but load up PG (>= v1.3.5 and <=1.3.6) somewhere and see how it doesn't save the history. I've observed this on two projects so far.
What should happen
What actually happens
...
...
4. The queries are no longer there when you reopen the same PG on the same browser
How to replicate
Get a PG (>= v1.3.5 and <=1.3.6) up and running in any project (my favourite is to create a new one with graphql-yoga). I tried also on https://www.graphqlbin.com/Agjcr and it breaks there, too. When I open it, there's a history available there already (not from me), but any new queries do not persist.
The text was updated successfully, but these errors were encountered: