Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History and Headers aren't persisted #317

Closed
2 tasks
danwkennedy opened this issue Dec 6, 2017 · 8 comments
Closed
2 tasks

History and Headers aren't persisted #317

danwkennedy opened this issue Dec 6, 2017 · 8 comments

Comments

@danwkennedy
Copy link

This issue pertains to:

  • GraphQL Playground - Electron App
  • GraphQL Playground
  • [ x ] GraphQL Playground Middleware

What OS and OS version are you experiencing the issue(s) on?

MacOS High Sierra

What version of graphql-playground(-electron/-middleware) are you experience the issue(s) on?

graphql-playground-middleware-koa: 1.3.6

What is the expected behavior?

The previous version we were on persisted the query history and headers when the page was refreshed.

What is the actual behavior?

The headers and history are cleared when the page refreshes. This causes some churn with Authorize headers needing to be set again in the case of the headers clearing. The history also becomes unusable since you can't see your history from previous development sessions.

What steps may we take to reproduce the behavior?

@cjoudrey
Copy link

cjoudrey commented Dec 10, 2017

I think this is a bit of a deal breaker for people especially if they need to re-enter a Authorization header each time they boot the app.

I haven't taken a look, but we should be able to figure out what broke this feature using a git bisect once we know a previous version where this feature worked.

@vincenzo
Copy link
Contributor

I believe this is the same as mine #312 -- If so, I can the "headers" bit there and we can close this one?

@vincenzo
Copy link
Contributor

@timsuchanek @sorenbs

@timsuchanek
Copy link
Member

Thanks for reporting @danwkennedy !
We will fix it in the coming days!

@vincenzo
Copy link
Contributor

Hey, I had reported this days before :D

@vincenzo
Copy link
Contributor

Can't wait for this to be fixed, to be honest.

@schickling
Copy link
Collaborator

This should be fixed in 1.3.10 🎉

@cjoudrey
Copy link

Nice! I’ll bump the version in brew cask later if nobody does it before me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants