-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: side tabs resize #1077
base: main
Are you sure you want to change the base?
fix: side tabs resize #1077
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! good catch on this regression, thanks!
Is there any progress on this one. It's a pretty annoying little bug! 😅 We're nearly 1 year on now. |
Agreed, this is a really frustrating tiny bug. Could we please try to get this merged? |
@spencersteers do you want to update this for the failing typescript check? |
@@ -269,6 +267,7 @@ const ConnectedGraphDocs = connect<StateFromProps, DispatchFromProps, Props>( | |||
{ forwardRef: true }, | |||
)(SideTabs) | |||
|
|||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find anything actually using SideTabs.Tab
but I'm not sure how this package is used and something could be depending on it.
@acao Types are hopefully fixed.. I haven't used the playground in about 6 months but I noticed that only the schema tab is resizable. I tracked down where I think the problem is: https://github.com/spencersteers/graphql-playground/blob/fix-side-tabs-resize/packages/graphql-playground-react/src/components/Playground/DocExplorer/GraphDocs.tsx#L122 - seems to be using it's own logic for width. If I still used the playground I would feel more comfortable with fixing it but It has been a long time and I won't be using playground anytime soon. Best of luck. |
can this be merged ? |
@seansnyder we will get to this once there is a working fix, or I have time to work on fixing this issue. this PR no longer fixes the issue with resizing the docs sidebar, according to the latest netlify deploy above |
I don't have time to work on this bug unfortunately. Does someone want to update this PR or provide a new PR that fixes the issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not seem to fix the resizing issue, unless I'm mistaken?
Fixes side tab resizing
Changes proposed in this pull request:
changeWidthDocs
so that the tabs can resizeThis issue was originally reported in apollographql/apollo-server#2529 and was fixed in apollographql#19.
The regression looks like it was introduced in #1001.