Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: side tabs resize #1077

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

spencersteers
Copy link

Fixes side tab resizing

Changes proposed in this pull request:

  • Bind missing action changeWidthDocs so that the tabs can resize

This issue was originally reported in apollographql/apollo-server#2529 and was fixed in apollographql#19.

The regression looks like it was introduced in #1001.

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ acao
❌ spencersteers
You have signed the CLA already but the status is still pending? Let us recheck it.

@acao acao changed the title Fix side tabs resize fix: side tabs resize Apr 6, 2020
Copy link
Member

@acao acao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! good catch on this regression, thanks!

@seeruk
Copy link

seeruk commented Jul 12, 2020

Is there any progress on this one. It's a pretty annoying little bug! 😅 We're nearly 1 year on now.

@seansnyder
Copy link

Agreed, this is a really frustrating tiny bug. Could we please try to get this merged?

@acao
Copy link
Member

acao commented Jul 14, 2020

@spencersteers do you want to update this for the failing typescript check?
or does someone else want to re-create this PR and give him credit in the commit with a Co-Authored-By in the footer?
otherwise, I can update this PR myself tomorrow

@@ -269,6 +267,7 @@ const ConnectedGraphDocs = connect<StateFromProps, DispatchFromProps, Props>(
{ forwardRef: true },
)(SideTabs)

// @ts-ignore
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find anything actually using SideTabs.Tab but I'm not sure how this package is used and something could be depending on it.

@spencersteers
Copy link
Author

@acao Types are hopefully fixed..

I haven't used the playground in about 6 months but I noticed that only the schema tab is resizable. I tracked down where I think the problem is: https://github.com/spencersteers/graphql-playground/blob/fix-side-tabs-resize/packages/graphql-playground-react/src/components/Playground/DocExplorer/GraphDocs.tsx#L122 - seems to be using it's own logic for width.

If I still used the playground I would feel more comfortable with fixing it but It has been a long time and I won't be using playground anytime soon. Best of luck.

@seansnyder
Copy link

can this be merged ?

@acao
Copy link
Member

acao commented Jul 30, 2020

@seansnyder we will get to this once there is a working fix, or I have time to work on fixing this issue. this PR no longer fixes the issue with resizing the docs sidebar, according to the latest netlify deploy above

@acao
Copy link
Member

acao commented Aug 29, 2020

I don't have time to work on this bug unfortunately. Does someone want to update this PR or provide a new PR that fixes the issue?

Copy link
Member

@acao acao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not seem to fix the resizing issue, unless I'm mistaken?

@acao acao added the needs work label Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants