Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure algorithms demonstrate proper punctuation #1067

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Dec 7, 2023

@graphql/tsc prize for smallest editorial change?

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit a2c4ec1
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/65722a649c77fc00081b4531
😎 Deploy Preview https://deploy-preview-1067--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benjie
Copy link
Member

benjie commented Dec 7, 2023

I think there's quite a few places in the spec with inconsistent use of fullstops in algorithm steps. Please detail the correct pattern in the STYLE_GUIDE and address all algorithms throughout 👍

@benjie benjie added the ✏️ Editorial PR is non-normative or does not influence implementation label Dec 7, 2023
@yaacovCR yaacovCR changed the title add missing period ensure algorithms end with periods Dec 7, 2023
@yaacovCR yaacovCR changed the title ensure algorithms end with periods ensure algorithms demonstrate proper pronunciation Dec 7, 2023
@yaacovCR
Copy link
Contributor Author

yaacovCR commented Dec 7, 2023

I think there's quite a few places in the spec with inconsistent use of fullstops in algorithm steps. Please detail the correct pattern in the STYLE_GUIDE and address all algorithms throughout 👍

I searched for a few using regex, but I could only semi-automate, so I am quite sure that I may have missed a few or more.

@yaacovCR yaacovCR changed the title ensure algorithms demonstrate proper pronunciation ensure algorithms demonstrate proper punctuation Dec 7, 2023
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks! 🙌

@benjie benjie merged commit feac5a5 into graphql:main Dec 14, 2023
7 checks passed
@yaacovCR yaacovCR deleted the add-missing-period branch February 8, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editorial PR is non-normative or does not influence implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants