-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update schema and types docs #1800
Conversation
Simplify description of Query and Mutation types. I think it's safe not to introduce the `schema` keyword in the second page that beginners will come to when learning about GraphQL. Changing the names of the root operation types is, I assume, rare, and so I'm suggesting with these edits to omit going into that detail.
@mandiwise is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
If possible, please rebase these changes onto #1794 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should be linking to the draft spec rather than a specific release. Everything in the draft has passed the RFC process and barring some exceptional circumstances will make it into the next official release - it's the version that implementations should be following/implementing, and the links are more evergreen (linking to section titles should be fine, but linking to specific words within a paragraph is probably riskier!).
@benjie I'm happy to swap out the URLs to use the draft spec path so they're more stable over time. The other option I can think of would be to create something like a |
Co-authored-by: Benjie <benjie@jemjie.com>
The MDX component is an interesting approach! I think we should just link to the draft - our general advice to everyone is to follow the draft, and the draft is where any typo fixes and other such things will go so it's generally more correct/up-to-date. |
Spec links have now been changed to the draft path. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent! I've included some suggested edits, but I think this is a great improvement over the existing text - excellent work 🙌
Co-authored-by: Benjie <benjie@jemjie.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good just the bulleted list of schema build methods and maybe the linking of the defined terms left to consider I think!
These changes have been committed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome; this is great! 🙌
Co-authored-by: Benjie <benjie@jemjie.com> Co-authored-by: Jonathan Berger <Jonathanberger@gmail.com>
Co-authored-by: Benjie <benjie@jemjie.com> Co-authored-by: Jonathan Berger <Jonathanberger@gmail.com>
Description
This PR contains updated content for the Schema and Types page in the Learn docs. Key changes include:
Note that the intention is to swap the order of this page in the left nav so that it comes before the Queries and Mutations content, but this will be addressed in the next PR that updates that operation-related content.
@benjie @jorydotcom