-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update authorization and pagination docs #1814
base: source
Are you sure you want to change the base?
Conversation
@mandiwise is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some really good changes here, but I'm not sure about "Using type system directives" being included?
src/pages/learn/authorization.mdx
Outdated
|
||
## Using type system directives | ||
|
||
In the example above, we saw how authorization logic can be delegated to the business logic layer through a function that is called in a field resolver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following on from https://github.com/graphql/graphql.github.io/pull/1814/files#r1852923240
Instead of trying to fit the auth directive approach into the "business logic layer" narrative, let's explicitly call it out as an alternative - something that people do but is not the recommended way:
In the example above, we saw how authorization logic can be delegated to the business logic layer through a function that is called in a field resolver. | |
In the example above, we saw how authorization logic can be delegated to the business logic layer through a function that is called in a field resolver. In general it is recommended to perform all authorization logic in the business logic layer, however if you decide to implement authorization in the GraphQL layer instead then one approach is to use [type system dire... |
(merge with next paragraph)
The remainder of the text in this section would also need light editorial to reflect this.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, addressed in 587906a.
We're back to 136 files changed @mandiwise; I think something went wrong with your merge/rebase |
587906a
to
4cc50e2
Compare
@benjie Update: I dug into this further was able to figure out what needed to be done for the PR to be re-openable. I was also able to remove the duplicated file changes from the source branch again. |
Co-authored-by: Benjie <benjie@jemjie.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to go to me! 🙌
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Description
This PR contains updated authorization and pagination content for the Learn docs. Key changes include:
postRepository
code example has been expanded for clarity@benjie @jorydotcom