Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links that are broken until other pages ship. #1836

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

mandiwise
Copy link
Contributor

Description

Fixes #1834 and #1835.

@benjie

Copy link

vercel bot commented Nov 25, 2024

@mandiwise is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mandi; so to be clear we should revert this once the following have shipped?

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 4:56pm

@benjie
Copy link
Member

benjie commented Nov 25, 2024

I've merged #1802 and dropped that change.

@benjie benjie merged commit 96e2503 into graphql:source Nov 25, 2024
2 of 3 checks passed
@mandiwise
Copy link
Contributor Author

@benjie Correct, this should be reverted once the subscriptions and performance pages are live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Found broken /learn/subscriptions link from https://graphql.org/learn/serving-over-http/. Please fix!
2 participants