Skip to content

Commit

Permalink
Replace EOL Debian Buster with Bullseye in Dockerfile-node (#47204)
Browse files Browse the repository at this point in the history
* Use Debian Bullseye instead of EOL Debian Buster

* Update Node.js to 20.17
  • Loading branch information
gzdunek authored Oct 4, 2024
1 parent 7b0e857 commit 62abc57
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
11 changes: 6 additions & 5 deletions build.assets/Dockerfile-node
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,18 @@
# to build the Teleport Connect. It can also be used to build the
# web assets for the Teleport UI.
#
# This image is base on the node image, which is based on Debian Buster.
# Using it as a image allows us to link agains the same version of
# glibc as Node.js.
# This image is base on the node image, which is based on Debian Bullseye.
# Using it as an image allows us to link against the oldest version of glibc
# supported by Node.js Docker images.
#
# Check the README to learn how to safely introduce changes to Dockerfiles.

## BUILDBOX-NODE ###################################################################

# Pin the tag to Debian Buster to make sure the Glibc compatibility.
# Pin the tag to Debian Bullseye to make sure the glibc compatibility
# (glibc version of Bullseye is 2.31).
ARG NODE_VERSION
FROM node:${NODE_VERSION}-buster AS buildbox
FROM node:${NODE_VERSION}-bullseye AS buildbox

# BUILDARCH is automatically set by DOCKER when building the image with Build Kit (MacOS by deafult).
# https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope
Expand Down
2 changes: 1 addition & 1 deletion build.assets/versions.mk
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
GOLANG_VERSION ?= go1.23.2
GOLANGCI_LINT_VERSION ?= v1.61.0

NODE_VERSION ?= 20.14.0
NODE_VERSION ?= 20.17.0

# Run lint-rust check locally before merging code after you bump this.
RUST_VERSION ?= 1.81.0
Expand Down

0 comments on commit 62abc57

Please sign in to comment.