pam: free the CString allocated for pam_putenv

gravitational · May 19, 2020 · 9d33512 · 9d33512
1 parent 8eb624a
commit 9d33512
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/pam/pam.go b/lib/pam/pam.go
@@ -291,6 +291,8 @@ func Open(config *Config) (*PAM, error) {
 		// Also set it via PAM-specific pam_putenv, which is respected by
 		// pam_exec (and possibly others), where parent env vars are not.
 		kv := C.CString(fmt.Sprintf("%s=%s", k, v))
+		// pam_putenv makes a copy of kv, so we can free it right away.
+		defer C.free(unsafe.Pointer(kv))
 		retval := C._pam_putenv(pamHandle, p.pamh, kv)
 		if retval != C.PAM_SUCCESS {
 			return nil, p.codeToError(retval)