fix typo

gravitational · Jan 14, 2025 · cdbc9c0 · cdbc9c0
1 parent fe9d532
commit cdbc9c0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/api/proto/teleport/legacy/types/types.proto b/api/proto/teleport/legacy/types/types.proto
@@ -7624,7 +7624,7 @@ message IntegrationV1 {
 message IntegrationStatusV1 {
   // PendingUserTasksNotificationID contains the notification ID that indicates that this integration has unresolved user tasks.
   string PendingUserTasksNotificationID = 1 [(gogoproto.jsontag) = "pending_user_tasks_notification_id,omitempty"];
-  // NeedsAttentionNotificationExpires contains the expiration date for the notification.
+  // PendingUserTasksNotificationExpires contains the expiration date for the notification.
   // Used to ensure new notifications' expiration is the greater between the current notification and the new one.
   google.protobuf.Timestamp PendingUserTasksNotificationExpires = 2 [
     (gogoproto.stdtime) = true,

diff --git a/api/types/types.pb.go b/api/types/types.pb.go
diff --git a/lib/auth/usertasks/usertasksv1/service.go b/lib/auth/usertasks/usertasksv1/service.go
@@ -475,8 +475,7 @@ func (s *Service) notifyUserAboutPendingTask(ctx context.Context, ut *usertasksv
 		return trace.Wrap(err)
 	}
 	integrationStatus := integration.GetStatus()
-	existingNotification := integrationStatus.PendingUserTasksNotificationID
-	if existingNotification != "" {
+	if integrationStatus.PendingUserTasksNotificationID != "" {
 		if err := s.backend.DeleteGlobalNotification(ctx, integrationStatus.PendingUserTasksNotificationID); err != nil {
 			// NotFound might be returned when the GlobalNotification already expired or was deleted.
 			if !trace.IsNotFound(err) {

diff --git a/lib/srv/discovery/status.go b/lib/srv/discovery/status.go
@@ -547,7 +547,7 @@ func (s *Server) acquireSemaphore(kind, semaphoreName string) (releaseFn func(),
 
 // acquireSemaphoreForIntegration tries to acquire a semaphore lock for the integration.
 // This allows the process to do two things:
-// - merge the current UserTask with the one stored in the backend, so that no discover-ec2.instance is lost
+// - merge the current UserTask with the one stored in the backend, so that no task items are lost
 // - ensure a single Notification (pending-user-task-integration) is created
 // The former could be achieved using the UserTask name as lock identifier.
 // However, for the latter, we would need a lock for the Integration.