WebUI tty doesn't handle websocket error messages from the server. #42626
Comments
zmb3
added a commit
that referenced
this issue
Jun 24, 2024
We never implemented UI support for the websocket error message, so errors were never surfaced to users. This also uncovered one case where we were sending invalid data (due to a missing version number). Closes #42626
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 25, 2024
We never implemented UI support for the websocket error message, so errors were never surfaced to users. This also uncovered one case where we were sending invalid data (due to a missing version number). Closes #42626
github-actions bot
pushed a commit
that referenced
this issue
Jun 25, 2024
We never implemented UI support for the websocket error message, so errors were never surfaced to users. This also uncovered one case where we were sending invalid data (due to a missing version number). Closes #42626
zmb3
added a commit
that referenced
this issue
Jun 25, 2024
We never implemented UI support for the websocket error message, so errors were never surfaced to users. This also uncovered one case where we were sending invalid data (due to a missing version number). Closes #42626
zmb3
added a commit
that referenced
this issue
Jun 25, 2024
We never implemented UI support for the websocket error message, so errors were never surfaced to users. This also uncovered one case where we were sending invalid data (due to a missing version number). Closes #42626
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 25, 2024
We never implemented UI support for the websocket error message, so errors were never surfaced to users. This also uncovered one case where we were sending invalid data (due to a missing version number). Closes #42626
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 26, 2024
We never implemented UI support for the websocket error message, so errors were never surfaced to users. This also uncovered one case where we were sending invalid data (due to a missing version number). Closes #42626
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 26, 2024
We never implemented UI support for the websocket error message, so errors were never surfaced to users. This also uncovered one case where we were sending invalid data (due to a missing version number). Closes #42626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior:
tty in the web UI to handle error message set from the server over websocket and display it.
Current behavior:
Fails to process unknown message type if you return an error in the handler:
The text was updated successfully, but these errors were encountered: