Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine ID: Document the 24 hour maximum certificate TTL #44894

Closed
timothyb89 opened this issue Jul 31, 2024 · 0 comments · Fixed by #44907
Closed

Machine ID: Document the 24 hour maximum certificate TTL #44894

timothyb89 opened this issue Jul 31, 2024 · 0 comments · Fixed by #44907

Comments

@timothyb89
Copy link
Contributor

timothyb89 commented Jul 31, 2024

Applies To

Details

Machine ID has a hard-coded server-side 24 hour limit to the certificate_ttl config parameter. This is defined for security purposes, to encourage the use of short lived and renewable certificates. The limit can be surprising to users, however, and I was not able to find any public-facing discussion of why we set it in the docs.

How will we know this is resolved?

The limit should be made clear on the reference documentation, and an FAQ entry may be appropriate as this does come up occasionally. A mention of the limit in the Architecture page may also be worthwhile.

Related Issues

timothyb89 added a commit that referenced this issue Aug 1, 2024
This adds some notes to the Machine ID docs explaining that a TTL
limit exists, and an explanation in the FAQ explaining why. It also
adds a logged warning on bot startup if the TTL request exceeds the
server limit.

Fixes #44894
github-merge-queue bot pushed a commit that referenced this issue Aug 1, 2024
This adds some notes to the Machine ID docs explaining that a TTL
limit exists, and an explanation in the FAQ explaining why. It also
adds a logged warning on bot startup if the TTL request exceeds the
server limit.

Fixes #44894
github-actions bot pushed a commit that referenced this issue Aug 1, 2024
This adds some notes to the Machine ID docs explaining that a TTL
limit exists, and an explanation in the FAQ explaining why. It also
adds a logged warning on bot startup if the TTL request exceeds the
server limit.

Fixes #44894
github-actions bot pushed a commit that referenced this issue Aug 1, 2024
This adds some notes to the Machine ID docs explaining that a TTL
limit exists, and an explanation in the FAQ explaining why. It also
adds a logged warning on bot startup if the TTL request exceeds the
server limit.

Fixes #44894
github-merge-queue bot pushed a commit that referenced this issue Aug 2, 2024
This adds some notes to the Machine ID docs explaining that a TTL
limit exists, and an explanation in the FAQ explaining why. It also
adds a logged warning on bot startup if the TTL request exceeds the
server limit.

Fixes #44894
github-merge-queue bot pushed a commit that referenced this issue Aug 2, 2024
This adds some notes to the Machine ID docs explaining that a TTL
limit exists, and an explanation in the FAQ explaining why. It also
adds a logged warning on bot startup if the TTL request exceeds the
server limit.

Fixes #44894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant