[v7] Switch to forked httprouter and enable UseRawPath option (#11068)
#12109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use forked httprouter with RawPath fix: gravitational/httprouter * Enable UseRawPath everywhere. * Test: allow MFA devices with `/` in names to be deleted Co-authored-by: Przemko Robakowski <przemko.robakowski@goteleport.com>
codingllama
approved these changes
Apr 20, 2022
zmb3
approved these changes
Apr 20, 2022
probakowski
approved these changes
Apr 20, 2022
atikhono
added a commit
to joomcode/Burrow
that referenced
this pull request
Aug 7, 2024
Our kafka entities (e.g. consumer group names) contain unsafe symbols, such as forward slash and colon. This change forces Burrow (httprouter) to use encoded paths in URLs (Burrow plugin for Telegraf has always used PathEscape from "net/url" to form Burrow URLs). With raw path support, we do not loose metrics for groups with unsafe symbols in name. Original pull request to support raw path in httprouter: julienschmidt/httprouter#209, waiting for merge since 2017. Looks like httprouter was abandoned around 2019. The author switched to their own fork: gravitational/teleport#12109. Let's do the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to v7: #11068
Use forked httprouter with RawPath fix: gravitational/httprouter
Enable UseRawPath everywhere.
Test: allow MFA devices with
/in names to be deletedCo-authored-by: Przemko Robakowski przemko.robakowski@goteleport.com