[v12] Remove grpc-teleterm Make target and Dockerfile-teleterm #20758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was used to format protos but we use Buf for that since v10.
This commit basically takes grpc_node_plugin compilation from Dockerfile-teleterm and moves it to Dockerfile.
After moving grpc_node_plugin compilation to Dockerfile, the only remaining thing that Dockerfile-teleterm does is installing rpm so that we can make an RPM package for Connect during tag builds. Installing this package can be simply moved to Dockerfile.
It looks like they're a result of someone changing protos in lib/prehog without running `make grpc-teleterm` separately. Which is why we're getting rid of grpc-teleterm as a separate Make target in the first place. ;)
mdwn
approved these changes
Jan 26, 2023
fspmarshall
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #20032 to branch/v12