[v13] Update docker images #27502
[v13] Update docker images #27502
Conversation
* Update base Ubuntu image to 22.04 * Revert the ubuntu image to 20.04 * Update the Dockerfile comment * Add CentOS 7 note * Add Connect note
* Move Connect build to a new Docker container * Update comments * Update comments Remove unused packages and unused arguments * Always use UID=1000 for building teleterm.
There was a problem hiding this comment.
Requesting changes until we understand how this affects our glibc compatibility.
Moreover, I'm not sure if this should be backported to stable release branches at all tbh to avoid breaking compatibility mid-release. We've been there before and it generates support load. Is there a reason we'd want to backport?
| @@ -96,7 +94,7 @@ RUN mkdir -p /opt && cd /opt && \ | |||
| # 4. Fast, language-dependent dependencies | |||
| # 5. Multi-stage layer copies | |||
|
|
|||
| FROM ubuntu:18.04 AS buildbox | |||
| FROM ubuntu:20.04 AS buildbox | |||
There was a problem hiding this comment.
I might have missed it in the original discussion, but wouldn't bumping version to 20.04 raise our minimum glibc version requirement?
There was a problem hiding this comment.
I want to backport this as Ubuntu 18.04 is EOL. Bumping the glibc version on the buildbox won't change the glibc version required by Teleport as we're using CentOS 7 for Teleport and the new Connect image for Teleport Connect releases.
There was a problem hiding this comment.
Please make sure @r0mant is happy with the changes before merging this or the other backports, otherwise LGTM.
public-teleport-github-review-bot
bot
removed the request for review
from gzdunek
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Backport of #27175 and #26905