Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --skip-idle-time flag to tsh play #39266

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Add a --skip-idle-time flag to tsh play #39266

merged 2 commits into from
Jul 10, 2024

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Mar 12, 2024

This tells tsh to respect timing data (and the configured playback speed) while there is active recording data, but to skip over larger periods of idle time.

changelog: Add a --skip-idle time flag to tsh play.

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions github-actions bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Mar 12, 2024
@github-actions github-actions bot requested review from GavinFrazar and jakule March 12, 2024 19:28
Copy link
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

This tells tsh to respect timing data (and the configured playback
speed) while there is active recording data, but to skip over larger
periods of idle time.
@zmb3 zmb3 force-pushed the zmb3/tsh-play-skip-idle branch from f361776 to 9238a44 Compare June 28, 2024 17:35
@jakule
Copy link
Contributor

jakule commented Jul 10, 2024

@zmb3 Can we merge it?

@zmb3 zmb3 enabled auto-merge July 10, 2024 15:19
@zmb3 zmb3 added this pull request to the merge queue Jul 10, 2024
Merged via the queue into master with commit 4b9d085 Jul 10, 2024
39 checks passed
@zmb3 zmb3 deleted the zmb3/tsh-play-skip-idle branch July 10, 2024 15:55
@public-teleport-github-review-bot

@zmb3 See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Failed
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v14 backport/branch/v15 backport/branch/v16 size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants