Use Restart=always for the Teleport systemd service
#41564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sclevine
approved these changes
May 14, 2024
bernardjkim
approved these changes
May 14, 2024
zmb3
approved these changes
May 14, 2024
r0mant
approved these changes
May 14, 2024
tigrato
approved these changes
May 15, 2024
|
@espadolini See the table below for backport results.
|
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current systemd unit file for Teleport uses
Restart=on-failure, but we just noticed a race condition that could cause Teleport to get terminated by an unhandled HUP signal, which systemd treats as a "clean" exit state. Seeing as theteleportbinary will never exit on its own volition except after spawning a brand newteleportand checking that it's running, this PR sets the restart behavior toalwaysinstead.Of note is that
Restart=alwayswill not restart the service if it's manually stopped viasystemctl stopand similar systemd-level controls, only if the process exits "cleanly" (which is a bug).changelog: ensured that systemd always restarts Teleport on any failure unless explicitly stopped