[v15] Convert App heartbeats to use the inventory control stream #41626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
approved these changes
May 17, 2024
zmb3
approved these changes
May 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Updates app server heartbeats to use srv.Heartbeatv2 in order to leverage the inventory control stream instead of the legacy mechanism. The new srv.heartbeatV2Driver implementation for app servers detects the version of Auth and falls back appropriately if the Auth server is too old to know about the new field added to the InventoryHeartbeat message. The connected_resources metric should be accurate if the auth and app service are on the same version or if the auth service is on a more recent version. If the app service is newer than auth and the new app server driver kicks into fall back mode then the connected resource metric will not be updated. Partially addresses #40917
rosstimothy
force-pushed
the
tross/backport-41164/v15
branch
from
b7012f9 to
f2f505f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #41164 to branch/v15
Changelog: Allow the application service to heartbeat on behalf of more than 1000 dynamic applications.