Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v15] Add access monitoring rules cache and tctl interactions #42092

Merged
merged 5 commits into from
May 29, 2024

Conversation

EdwardDowling
Copy link
Contributor

@EdwardDowling EdwardDowling commented May 28, 2024

backport of #40218

changelog: Added ability to manage access monitoring rules via tctl

EdwardDowling and others added 2 commits May 28, 2024 17:21
* Add access monitoring rules cache and tctl interactions

* Swap access monitoring rules collections to use upsert

* Update accessmonitoringrules cache test

* Readd missing err check

* Update lib/auth/grpcserver.go

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>

* Update lib/auth/grpcserver.go

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>

* Update tool/tctl/common/resource_command.go

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>

* Add tctl isForced behaviour for access monitoring rules

* Add missing methods to cache interface for access monitoring rules

* Add info messages to tctl commands for accessmonitoring rule edits

* Add missing user message for forced rule creation

* Appease linter

---------

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
@EdwardDowling EdwardDowling marked this pull request as ready for review May 28, 2024 16:28
@github-actions github-actions bot requested a review from fspmarshall May 28, 2024 16:29
@github-actions github-actions bot added backport size/md tctl tctl - Teleport admin tool labels May 28, 2024
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from fspmarshall May 28, 2024 17:53
@EdwardDowling EdwardDowling added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@EdwardDowling EdwardDowling added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@EdwardDowling EdwardDowling added this pull request to the merge queue May 29, 2024
Merged via the queue into branch/v15 with commit 7e3b247 May 29, 2024
31 checks passed
@EdwardDowling EdwardDowling deleted the edwarddowling/backport/backport-40218/v15 branch May 29, 2024 12:15
@camscale camscale mentioned this pull request May 31, 2024
@ghost ghost mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/md tctl tctl - Teleport admin tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants