[v14] dynamoevents: Fix panic if cursor is outside of [fromUTC,toUTC] range #42266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If clients send a request where the cursor falls outside of the [From.UTC,To.UTC] interval, dynamodbevents will panic after consuming all possible values in `dates`. This happens because `dates` is an array of full days between `[from,to]`. The patched for loop tried to discard days that were already consumed by the latest request but if the cursor fall outside of this window, the loop consumed all days and eventually panic. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-actions
bot
added
audit-log
zmb3
approved these changes
Jun 1, 2024
marcoandredinis
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #42247 to branch/v14
changelog: Fixed a panic in the DynamoDB audit log backend when the cursor fell outside of the [From,To] interval