[v14] dynamoevents: ensure cursor belongs to [fromUTC,toUTC] #42914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ensures that the cursor if the cursor doesn't belong to [fromUTC,toUTC], the request is adapted before sending it to DynamoDB. When the cursor falls outside of the window either because `t<fromUTC` or `t>toUTC`, we must avoid calling DynamoDB because the query will fail with `The provided starting key does not match the range key predicate`. To prevent errors, this PR clears the cursor if `t<fromUTC` and returns empty if `t>toUTC`. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-actions
bot
added
audit-log
rosstimothy
approved these changes
Jun 13, 2024
marcoandredinis
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #42865 to branch/v14
changelog: Fixes errors caused by
dynamoeventsqueryStartKeynot being within the [From, To] window.