Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opsgenie team responders support #43535

Merged
merged 12 commits into from
Jul 8, 2024
Merged

Opsgenie team responders support #43535

merged 12 commits into from
Jul 8, 2024

Conversation

EdwardDowling
Copy link
Contributor

@EdwardDowling EdwardDowling commented Jun 26, 2024

Buddy PR for 43281

Currently, when creating an Opsgenie alert with the Opsgenie integration, responders can only be of type schedule.
However that are situations where type teams are required to work with Opsgenie integrations, as well, teams takes multiple schedules into consideration, such as escalations schedules.

Instead of changing the teleport.dev/notify-services annotation to support teams by default, I purpose adding a new annotation teleport.dev/teams that will contains the respective teams and the result will be a merge of both annotations to the responders payload.

Teleport role:

kind: role
metadata:
  name: prod-write-teaccess-request
spec:
  allow:
    request:
      annotations:
        teleport.dev/schedules:
        - MySchedule
        teleport.dev/teams:
        - MyTeam
      roles:
      - prod-write-role

will be converted into Opsgenie payload

{
  "message": "Access request from ...",
  "alias": "....",
  "description":"....",
  "responders":[
  	{"name":"MySchedule", "type":"schedule"},
  	{"name":"MyTeam", "type":"team"}
  ],
  "priority":"P2"
}

Changelog: Add support for Teams to Opsgenie plugin alert creation

Signed-off-by: edward <edward@edwards-MacBook-Pro.local>
Copy link

🤖 Vercel preview here: https://docs-kculvdcp4-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-1w3eby5m0-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling marked this pull request as ready for review June 26, 2024 14:56
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

🤖 Vercel preview here: https://docs-irjv4fnum-goteleport.vercel.app/docs/ver/preview

@hugoShaka
Copy link
Contributor

Can we add a case in the test suite for this?

Signed-off-by: Edward Dowling <edward.dowling@goteleport.com>
Copy link

github-actions bot commented Jul 1, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

github-actions bot commented Jul 4, 2024

🤖 Vercel preview here: https://docs-ox3b6zmos-goteleport.vercel.app/docs/ver/preview

Copy link

github-actions bot commented Jul 5, 2024

🤖 Vercel preview here: https://docs-dzmvyp2yg-goteleport.vercel.app/docs/ver/preview

Copy link

github-actions bot commented Jul 5, 2024

🤖 Vercel preview here: https://docs-1ngl2sh8m-goteleport.vercel.app/docs/ver/preview

Copy link

github-actions bot commented Jul 5, 2024

🤖 Vercel preview here: https://docs-9tp20eppz-goteleport.vercel.app/docs/ver/preview

Copy link

github-actions bot commented Jul 8, 2024

🤖 Vercel preview here: https://docs-3pzm6d1ea-goteleport.vercel.app/docs/ver/preview

Copy link

github-actions bot commented Jul 8, 2024

🤖 Vercel preview here: https://docs-16061jmkt-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling added this pull request to the merge queue Jul 8, 2024
Merged via the queue into master with commit 805381b Jul 8, 2024
42 checks passed
@EdwardDowling EdwardDowling deleted the edwarddowling/43281 branch July 8, 2024 14:03
@public-teleport-github-review-bot

@EdwardDowling See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Create PR

EdwardDowling added a commit that referenced this pull request Jul 17, 2024
Signed-off-by: Edward Dowling <edward.dowling@goteleport.com>
Co-authored-by: Carlos Castro <carlos.castro@jumo.world>
github-merge-queue bot pushed a commit that referenced this pull request Jul 29, 2024
* Opsgenie team responders support  (#43535)

Signed-off-by: Edward Dowling <edward.dowling@goteleport.com>
Co-authored-by: Carlos Castro <carlos.castro@jumo.world>

* Split schedules/teams into seperate alerts

* Update integrations/access/opsgenie/app.go

Co-authored-by: Nic Klaassen <nic@goteleport.com>

* aUpdate integrations/access/opsgenie/app.go

Co-authored-by: Nic Klaassen <nic@goteleport.com>

---------

Signed-off-by: Edward Dowling <edward.dowling@goteleport.com>
Co-authored-by: Carlos Castro <carlos.castro@jumo.world>
Co-authored-by: Nic Klaassen <nic@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants