[v14] Fix wrong context usage for reissuing expired certificate for tsh proxy kube. #43614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xy kube. (#43374) * Fix wrong context usage for reissuing expired certificate for tsh proxy kube. * Rename context to closeContext * Add test for request context expiration. * Add missing context in tests. * Remove flakiness from the test.
github-actions
bot
requested review from
marcoandredinis,
probakowski and
ravicious
github-actions
bot
added
size/sm
tsh
marcoandredinis
approved these changes
Jun 27, 2024
ravicious
approved these changes
Jun 28, 2024
public-teleport-github-review-bot
bot
removed the request for review
from probakowski
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #43374 to branch/v14
Manual backport because of a phantom conflict on neighbouring lines.
changelog: Wait for user MFA input when reissuing expired certificates for a kube proxy.