Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFD - Static host users #43666

Merged
merged 10 commits into from
Jul 17, 2024
Merged

RFD - Static host users #43666

merged 10 commits into from
Jul 17, 2024

Conversation

atburke
Copy link
Contributor

@atburke atburke commented Jun 28, 2024

This change adds an RFD for static host users. These are just like the users we provision for host user creation except they are provisioned ahead of time instead of when a user connects to a node.

Related: #42712.

@atburke atburke added the no-changelog Indicates that a PR does not require a changelog entry label Jun 28, 2024
@atburke atburke requested a review from rosstimothy June 28, 2024 23:00
@atburke atburke force-pushed the rfd/0175-static-host-users branch from 44e4edf to 4ca25f9 Compare July 9, 2024 23:01
@atburke atburke force-pushed the rfd/0175-static-host-users branch from 4ca25f9 to 4dbbb96 Compare July 12, 2024 16:13
@atburke atburke requested a review from lxea July 12, 2024 16:13
@atburke atburke marked this pull request as ready for review July 12, 2024 16:13
@github-actions github-actions bot added rfd Request for Discussion size/md labels Jul 12, 2024
@atburke atburke requested a review from espadolini July 12, 2024 16:41
rfd/0175-static-host-users.md Show resolved Hide resolved
rfd/0175-static-host-users.md Show resolved Hide resolved
rfd/0175-static-host-users.md Show resolved Hide resolved
rfd/0175-static-host-users.md Show resolved Hide resolved
@rosstimothy rosstimothy requested a review from espadolini July 16, 2024 23:01
Comment on lines 191 to 195
via `static_host_user`s. To that end, all host users created from `static_host_user`s
will be in the `teleport-created` group (similar to the `teleport-system` group, which
we currently use to mark users that Teleport should clean up). Teleport will not
delete users not in `teleport-created`, and new users will not override existing users
that are not in `teleport-created`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about existing, potentially ephemeral users in teleport-system? Will they be adopted into teleport-created? If so we'd have to be careful about what happens right around the Teleport upgrade that introduces this feature, if the cluster is already configured for it. I think that we could make the case that if the user is not ephemeral then there's no real reason to override it - and if it is ephemeral, it will eventually get cleaned up by not having a session and then the static configuration can kick in "naturally".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they won't be adopted. All users in teleport-system are ephemeral, so conflicts will be resolved after a session ends just as you described. In any case, I've renamed teleport-created to teleport-static to make it clearer that it's for marking static users, not all Teleport-created users.

Comment on lines +95 to +96
string uid = 4;
string gid = 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these strings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're strings here because they're strings in user traits, and I wanted to keep them the same.

@atburke atburke added this pull request to the merge queue Jul 17, 2024
Merged via the queue into master with commit 1ae3a69 Jul 17, 2024
38 checks passed
@atburke atburke deleted the rfd/0175-static-host-users branch July 17, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry rfd Request for Discussion size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants