-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Apply extraLabels to post-delete hooks in teleport-kube-agent chart #43866
Conversation
Fixes #43796 changelog: Relevant extraLabels configured in teleport-kube-agent chart values are now correctly applied to post-delete hooks
What about adding |
Good idea, this is better. Implemented in 6646889 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to re-render the docs with make -C examples/chart render-chart-ref
🤖 Vercel preview here: https://docs-ikqlekli1-goteleport.vercel.app/docs/ver/preview |
@webvictim See the table below for backport results.
|
I wasn't sure whether we should only have anextraLabels.hooks{}
object and apply this to all post-delete hooks, or propagate throughextraLabels
set on other resource types... so I did both. Alternative perspectives and/or comments on improvements very welcome.Adds the
extraLabels.job
value to propagate labels through to theJob
added by theteleport-kube-agent
chart as a post-delete hook. Labels set onRole
,RoleBinding
andServiceAccount
will also be propagated to the post-delete hooks for those elements.Fixes #43796
changelog: extraLabels configured in teleport-kube-agent chart values are now correctly propagated to post-delete hooks. A new
extraLabels.job
object has been added for labels which should only apply to the post-delete job.