Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Apply extraLabels to post-delete hooks in teleport-kube-agent chart #43866

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

webvictim
Copy link
Contributor

@webvictim webvictim commented Jul 4, 2024

I wasn't sure whether we should only have an extraLabels.hooks{} object and apply this to all post-delete hooks, or propagate through extraLabels set on other resource types... so I did both. Alternative perspectives and/or comments on improvements very welcome.

Adds the extraLabels.job value to propagate labels through to the Job added by the teleport-kube-agent chart as a post-delete hook. Labels set on Role, RoleBinding and ServiceAccount will also be propagated to the post-delete hooks for those elements.

Fixes #43796

changelog: extraLabels configured in teleport-kube-agent chart values are now correctly propagated to post-delete hooks. A new extraLabels.job object has been added for labels which should only apply to the post-delete job.

Fixes #43796

changelog: Relevant extraLabels configured in teleport-kube-agent chart values are now correctly applied to post-delete hooks
@hugoShaka
Copy link
Contributor

hugoShaka commented Jul 4, 2024

What about adding extraLabels.job instead of extraLabels.hooksso we can keep labeling things by type, regardless of the resources are part of the hooks or the long-lived release?

@webvictim
Copy link
Contributor Author

webvictim commented Jul 4, 2024

What about adding extraLabels.job instead of extraLabels.hooksso we can keep labeling things by type

Good idea, this is better.

Implemented in 6646889

@webvictim webvictim changed the title helm: Apply extraLabels to post-delete hooks helm: Apply extraLabels to post-delete hooks in teleport-kube-agent chart Jul 4, 2024
Copy link
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to re-render the docs with make -C examples/chart render-chart-ref

Copy link

github-actions bot commented Jul 4, 2024

🤖 Vercel preview here: https://docs-ikqlekli1-goteleport.vercel.app/docs/ver/preview

@webvictim webvictim added this pull request to the merge queue Jul 8, 2024
Merged via the queue into master with commit ade2a7b Jul 8, 2024
39 checks passed
@webvictim webvictim deleted the gus/helm/post-delete-hook-extralabels branch July 8, 2024 17:37
@public-teleport-github-review-bot

@webvictim See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chart] extraLabels do not apply for teleport-delete-hook
3 participants