-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workload Identity: Support Envoy SDS API #43958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardDowling
approved these changes
Aug 6, 2024
timothyb89
approved these changes
Aug 13, 2024
Need to rebase this ! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 14, 2024
Forgot to add backport labels :( |
strideynet
added a commit
that referenced
this pull request
Aug 14, 2024
* Start hacking on Workload Identity SDS API support * Actually generate from SVIDs/Trustbundle * Support for envoy "special meaning" resource names * Add minimum version enforcement * Simplify handling of clustername * Start working on StreamSecrets RPC * Extract response generation helper * Log request * Implemnt SDS versioning/nonce checking * Handle renewal of SDS certs * Refactor for ease of testing * Start writing tests for SDS functionality * Add E2E tests * Fix test * go mod tidy * Appease linter * Update go.mod * Fix test with characters that windows dislikes
strideynet
added a commit
that referenced
this pull request
Aug 14, 2024
* Start hacking on Workload Identity SDS API support * Actually generate from SVIDs/Trustbundle * Support for envoy "special meaning" resource names * Add minimum version enforcement * Simplify handling of clustername * Start working on StreamSecrets RPC * Extract response generation helper * Log request * Implemnt SDS versioning/nonce checking * Handle renewal of SDS certs * Refactor for ease of testing * Start writing tests for SDS functionality * Add E2E tests * Fix test * go mod tidy * Appease linter * Update go.mod * Fix test with characters that windows dislikes
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Start hacking on Workload Identity SDS API support * Actually generate from SVIDs/Trustbundle * Support for envoy "special meaning" resource names * Add minimum version enforcement * Simplify handling of clustername * Start working on StreamSecrets RPC * Extract response generation helper * Log request * Implemnt SDS versioning/nonce checking * Handle renewal of SDS certs * Refactor for ease of testing * Start writing tests for SDS functionality * Add E2E tests * Fix test * go mod tidy * Appease linter * Update go.mod * Fix test with characters that windows dislikes
vapopov
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Start hacking on Workload Identity SDS API support * Actually generate from SVIDs/Trustbundle * Support for envoy "special meaning" resource names * Add minimum version enforcement * Simplify handling of clustername * Start working on StreamSecrets RPC * Extract response generation helper * Log request * Implemnt SDS versioning/nonce checking * Handle renewal of SDS certs * Refactor for ease of testing * Start writing tests for SDS functionality * Add E2E tests * Fix test * go mod tidy * Appease linter * Update go.mod * Fix test with characters that windows dislikes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38666
Introduces support for the Envoy SDS API directly into the existing
spiffe-workload-api
service.I manually tested this with a simple envoy config:
httpbin
running on port7331
.spiffe-svid
output to obtain credentialsThere's probably a few rough edges with this that we'll discover as we try this out with tools like Istio - but I figure this PR is large enough as is. The key limitation I've noticed is that the SPIFFE validation configuration we return requires the client to authenticate, we may need to provide an option to return the more generic TLS validation configuration for use-cases which are not mTLS.
Example envoy config, tested using
httpbin
running on port7331
:And tbot config:
changelog: Introduce support for Envoy SDS into the Machine ID
spiffe-workload-api
service.