Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress.useExisting value #44009

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Add ingress.useExisting value #44009

merged 6 commits into from
Jul 12, 2024

Conversation

hugoShaka
Copy link
Contributor

@hugoShaka hugoShaka commented Jul 10, 2024

This PR adds a value allowing users to indicate they want to manage their own ingress but still want Teleport configured in ingress mode.

Changelog: The teleport-cluster chart can now use existing ingresses instead of creating its own.

Copy link

The PR changelog entry failed validation: The changelog entry must start with a letter.

Co-authored-by: Marco Dinis <marco.dinis@goteleport.com>
Copy link

🤖 Vercel preview here: https://docs-6zb79ymz7-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-7fxzgpwhx-goteleport.vercel.app/docs/ver/preview

examples/chart/teleport-cluster/values.yaml Outdated Show resolved Hide resolved
Co-authored-by: Gus Luxton <gus@goteleport.com>
Copy link

🤖 Vercel preview here: https://docs-geu0mwuzq-goteleport.vercel.app/docs/ver/preview

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from ptgott July 10, 2024 18:42
`values.yaml` example:

```yaml
ingress:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we start renaming this to the gateway api now that ingress api is frozen for quite some time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I checked the gateway API is optional, its CRDs are not here by default. This makes the adoption for generic tools like us very hard.

I can extend the ingress.useExisting documentation that users can manage their own ingress, or HTTProute if they want. Using TCPRoute is roughly equivalent to using a ServiceLB and we must not allow self-signed+replication in this setup. TLSRoute experience will depend on the configuration. I don't think we can just replace "ingress" by "gateway API" as the new gwapi is way more powerful and allows user to shoot themselves in the foot in brand new ways.

Users are also thinking about ingress when they need to expose a service (and they also sadly don't consider L4 LoadBalancer Services, this just makes Teleport slower and more complex to deploy). I think ingress is the name everyone is looking for and we should not rename this section.

examples/chart/teleport-cluster/values.yaml Outdated Show resolved Hide resolved
Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
Copy link

🤖 Vercel preview here: https://docs-nvf7czn6s-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-8wi4p3ir7-goteleport.vercel.app/docs/ver/preview

@hugoShaka hugoShaka added this pull request to the merge queue Jul 12, 2024
Copy link

🤖 Vercel preview here: https://docs-icogpui7x-goteleport.vercel.app/docs/ver/preview

Merged via the queue into master with commit f495b62 Jul 12, 2024
39 checks passed
@hugoShaka hugoShaka deleted the hugo/bring-your-own-ingress branch July 12, 2024 14:28
@public-teleport-github-review-bot

@hugoShaka See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants