-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingress.useExisting value #44009
Conversation
The PR changelog entry failed validation: The changelog entry must start with a letter. |
Co-authored-by: Marco Dinis <marco.dinis@goteleport.com>
🤖 Vercel preview here: https://docs-6zb79ymz7-goteleport.vercel.app/docs/ver/preview |
🤖 Vercel preview here: https://docs-7fxzgpwhx-goteleport.vercel.app/docs/ver/preview |
Co-authored-by: Gus Luxton <gus@goteleport.com>
🤖 Vercel preview here: https://docs-geu0mwuzq-goteleport.vercel.app/docs/ver/preview |
`values.yaml` example: | ||
|
||
```yaml | ||
ingress: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we start renaming this to the gateway api now that ingress api is frozen for quite some time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last time I checked the gateway API is optional, its CRDs are not here by default. This makes the adoption for generic tools like us very hard.
I can extend the ingress.useExisting
documentation that users can manage their own ingress, or HTTProute if they want. Using TCPRoute is roughly equivalent to using a ServiceLB and we must not allow self-signed+replication in this setup. TLSRoute experience will depend on the configuration. I don't think we can just replace "ingress" by "gateway API" as the new gwapi is way more powerful and allows user to shoot themselves in the foot in brand new ways.
Users are also thinking about ingress when they need to expose a service (and they also sadly don't consider L4 LoadBalancer Services, this just makes Teleport slower and more complex to deploy). I think ingress is the name everyone is looking for and we should not rename this section.
Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
🤖 Vercel preview here: https://docs-nvf7czn6s-goteleport.vercel.app/docs/ver/preview |
🤖 Vercel preview here: https://docs-8wi4p3ir7-goteleport.vercel.app/docs/ver/preview |
🤖 Vercel preview here: https://docs-icogpui7x-goteleport.vercel.app/docs/ver/preview |
@hugoShaka See the table below for backport results.
|
This PR adds a value allowing users to indicate they want to manage their own ingress but still want Teleport configured in ingress mode.
Changelog: The
teleport-cluster
chart can now use existing ingresses instead of creating its own.