[v14] Allow tsh ssh to use predicate expressions/search keywords from proxy templates #44031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… templates (#43983) While tsh ssh doesn't explicitly allow specifying predicate expressions or search keywords via the CLI they can be populated via a proxy template. However, the node resolution code in tsh only considered labels which results in confusing behavior, especially given the fact that debug logs indicate that a proxy template match was found and being used.
espadolini
approved these changes
Jul 10, 2024
tigrato
approved these changes
Jul 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #43983 to branch/v14
changelog: Honor proxy templates in
tsh ssh