[v14] Fixes a bug in the kube-agent-updater breaking private image resolution #44193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosign was receiving the registry options contianing the auth keychain, but its image resolution step was not. This caused the image resolution to fail. This went undetected because we tested on already digested images, so the resolution never happened. This commit fixes the issue, introduces new tests covering both authenticated registries and image resoluition. This commit also improves the error logging. When logging trust errors, we nmow log the original error to provide more context. This also adds more debug logging.
tigrato
approved these changes
Jul 13, 2024
marcoandredinis
approved these changes
Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #44112 to branch/v14
changelog: Fixed a
kube-agent-updaterbug affecting resolutions of private images.