Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Discover Server: add support for Rocky and Almalinux #44283

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

marcoandredinis
Copy link
Contributor

@marcoandredinis marcoandredinis commented Jul 16, 2024

This PR adds support for auto-enrolling Rocky and Almalinux distros.
We use the rhel channel because we don't have a specific channel for those distros, and they claim to be bug-for-bug compatible with rhel.

Demo:
image

image

changelog: Add Server auto discover support for Rocky and Almalinux distros

Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. have you tested this on these distros?

@marcoandredinis
Copy link
Contributor Author

lgtm. have you tested this on these distros?

I tested on Rocky Linux (see screenshot)
I'll test on Alma Linux before merging

@marcoandredinis marcoandredinis force-pushed the marco/autodiscoverserver_recover_badconfig branch 3 times, most recently from 5a041ab to f3be074 Compare July 19, 2024 07:23
Base automatically changed from marco/autodiscoverserver_recover_badconfig to master July 19, 2024 08:05
@marcoandredinis marcoandredinis force-pushed the marco/autodiscoverserver_check_idlike branch from c7c039a to 2ae69e8 Compare July 19, 2024 10:05
@marcoandredinis marcoandredinis added this pull request to the merge queue Jul 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2024
@marcoandredinis marcoandredinis force-pushed the marco/autodiscoverserver_check_idlike branch from 2ae69e8 to c60be2b Compare July 23, 2024 17:11
@marcoandredinis marcoandredinis added this pull request to the merge queue Jul 23, 2024
Merged via the queue into master with commit bd9f67b Jul 23, 2024
38 checks passed
@marcoandredinis marcoandredinis deleted the marco/autodiscoverserver_check_idlike branch July 23, 2024 20:19
@public-teleport-github-review-bot

@marcoandredinis See the table below for backport results.

Branch Result
branch/v16 Failed

marcoandredinis added a commit that referenced this pull request Jul 25, 2024
* Auto Discover Servers: recover from bad configuration

* Auto Discover Server: add support for Rocky and Almalinux

* fix license in test ts file
github-merge-queue bot pushed a commit that referenced this pull request Jul 26, 2024
…44612)

* Auto Discover Servers: recover from bad configuration

* Auto Discover Server: add support for Rocky and Almalinux

* fix license in test ts file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants