-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Discover Server: add support for Rocky and Almalinux #44283
Merged
marcoandredinis
merged 4 commits into
master
from
marco/autodiscoverserver_check_idlike
Jul 23, 2024
Merged
Auto Discover Server: add support for Rocky and Almalinux #44283
marcoandredinis
merged 4 commits into
master
from
marco/autodiscoverserver_check_idlike
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. have you tested this on these distros?
jakule
approved these changes
Jul 16, 2024
I tested on Rocky Linux (see screenshot) |
marcoandredinis
force-pushed
the
marco/autodiscoverserver_recover_badconfig
branch
3 times, most recently
from
July 19, 2024 07:23
5a041ab
to
f3be074
Compare
Base automatically changed from
marco/autodiscoverserver_recover_badconfig
to
master
July 19, 2024 08:05
marcoandredinis
force-pushed
the
marco/autodiscoverserver_check_idlike
branch
from
July 19, 2024 10:05
c7c039a
to
2ae69e8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 23, 2024
marcoandredinis
force-pushed
the
marco/autodiscoverserver_check_idlike
branch
from
July 23, 2024 17:11
2ae69e8
to
c60be2b
Compare
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
Jul 25, 2024
* Auto Discover Servers: recover from bad configuration * Auto Discover Server: add support for Rocky and Almalinux * fix license in test ts file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for auto-enrolling Rocky and Almalinux distros.
We use the rhel channel because we don't have a specific channel for those distros, and they claim to be bug-for-bug compatible with rhel.
Demo:
changelog: Add Server auto discover support for Rocky and Almalinux distros