[v14] Disable circuit breaking for proxies #44416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxy circuit breakers can be tripped by errors that may occur during joining, due to some configuration issues with the join mechanism, or potentially due to a malicious user hitting /webapi/ping too frequently. As a result the cluster can end up in an unusable state that can only be rectified by fixing the join token issue or turning off agents attempting to join. To avoid this class of problems entirely, the proxy circuit breaker is now a noop. While this does mean backoff during periods when auth connectivity is spotty will be reduced for proxies, they are usually far out numbered by agents in the cluster. Their lack of circuit breaking shouldn't exacerbate thundering herds.
fspmarshall
approved these changes
Jul 18, 2024
espadolini
approved these changes
Jul 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #44411 to branch/v14
changelog: Prevented DoSing the cluster during a mass failed join event by agents