[v15] Remove client side port guessing from tsh puttyconfig #44573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no port was provided puttyconfig would default to 3022. That is not guaranteed to be the correct port and causes UX issues. To allow the port to be optional and guarantee the correct port is used puttyconfig is updated to use 0 instead of 3022. This is a special port that indicates to Teleport to use whatever port is defined in the node when making dial request. Since the value from puttyconfig is fed into tsh proxy ssh this value is honored by Teleport during connections.
github-actions
bot
added
backport
size/sm
tsh
zmb3
approved these changes
Jul 23, 2024
espadolini
approved these changes
Jul 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #44478 to branch/v15
changelog: Use the registered port of the target host when
tsh puttyconfigis invoked without--port.