Machine ID: Use softer failure when unable to determine current user #44616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
changed the title
justinas
approved these changes
Jul 25, 2024
zmb3
approved these changes
Jul 25, 2024
public-teleport-github-review-bot
bot
removed the request for review
from timothyb89
timothyb89
approved these changes
Jul 25, 2024
|
@strideynet See the table below for backport results.
|
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20309
I've modified this failure to be softer. Previously, we were doing this lookup even if ACL checking was disabled or only set to try. I've made a note in #43554 for us to revisit this more thoroughly in the coming quarter as part of a general rework of how we handle filesystem permissions and ACLs.
changelog: Fixes a fatal error in
tbotwhen unable to lookup the user from a given UID in containerised environments for checking ACL configuration.