[v16] fix discovery overwriting dynamic resources #44785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the resource already exists, check its origin as well as discovery group. If it's not of discovery origin, then don't update it. If it's not in the same discovery group, and its discovery group is not blank, then don't update it.
AntonAM
approved these changes
Jul 30, 2024
rosstimothy
approved these changes
Jul 30, 2024
public-teleport-github-review-bot
bot
removed the request for review
from greedy52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #44316 to branch/v16
changelog: Prevent discovery service from overwriting Teleport dynamic resources that have the same name as discovered resources.