[v15] Improve copy/paste behavior in Connect terminal #45266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow reading clipboard content in renderer process * Make keyboard shortcuts to copy/paste text in terminal configurable, set reasonable defaults for Windows and Linux * Allow copying text in terminal with selection and a right click * Remove check for `selection.trim()`, check if there's something selected in callsites, rename `copy` to `copySelection` * Show copy/paste keyboard shortcuts in the context menu * Remove redundant `to` * Add `Copy in Terminal` and `Paste in Terminal` shortcuts to `KeyboardShortcutsPanel` * Set `rightClickSelectsWord: true` only if `terminal.rightClick` is `menu` * Add docs * Patched jsdom `global.matchMedia` should return `matches: false`, not `true` * Small docs correction (cherry picked from commit ee1a5ba)
ravicious
approved these changes
Aug 8, 2024
avatus
approved these changes
Aug 8, 2024
|
🤖 Vercel preview here: https://docs-lur4s7pjj-goteleport.vercel.app/docs/ver/preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #44871 to branch/v15
changelog: Improved copy and paste behavior in the terminal in Teleport Connect. On Windows and Linux, Ctrl+Shift+C/V now copies and pastes text (these shortcuts can be changed with
keymap.terminalCopy/keymap.terminalPaste). A mouse right click (terminal.rightClick) can copy/paste text too (enabled by default on Windows).