[v16] Make rejected connections easier to identify #45278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alert message now contains more information to allow admins to identify better whether the connection is from an agent or a user.
Prior version warnings were only emitted to users during login which can cause confusion if switching between versions while still possesing valid credentials on disk. Now when an error is detected that may have been from a version related rejection tsh will Ping the proxy to determine the minimum version. The Ping with connector endpoint was also update to populate the minimum client version.
zmb3
approved these changes
Aug 8, 2024
AntonAM
approved these changes
Aug 8, 2024
public-teleport-github-review-bot
bot
removed the request for review
from hugoShaka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #45176 to branch/v16
changelog: Improve discoverability of the source or rejected connections due to unsupported versions