Static host users - Add gRPC service #45292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atburke
added
the
no-changelog
rosstimothy
reviewed
Aug 9, 2024
rosstimothy
reviewed
Aug 12, 2024
rosstimothy
reviewed
Aug 12, 2024
| Authorizer authz.Authorizer | ||
| // Backend is the backend used to store static host users. | ||
| Backend services.StaticHostUser | ||
| // TODO(atburke): add cache |
There was a problem hiding this comment.
Let's also add a TODO in the places that are currently consuming from the backend that should be migrated to use the cache.
rosstimothy
reviewed
Aug 13, 2024
rosstimothy
reviewed
Aug 13, 2024
rosstimothy
approved these changes
Aug 14, 2024
greedy52
approved these changes
Aug 14, 2024
| }) | ||
| return err | ||
| }, | ||
| allowVerbs: []string{types.VerbCreate, types.VerbUpdate}, |
There was a problem hiding this comment.
nit: do we want to have a upsert test with only one of these verb?
This change adds the gRPC service for static host users.
atburke
force-pushed
the
atburke/static-user-grpc
branch
from
ddfd4f3 to
0ce9b3c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
atburke
added a commit
that referenced
this pull request
Sep 10, 2024
This change adds the gRPC service for static host users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the gRPC service for static host users (RFD 175).
Part of #42712.