Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube] init stsclient when assuming a role #45306

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

tigrato
Copy link
Contributor

@tigrato tigrato commented Aug 9, 2024

When assuming a role, we didn't properly init a.stsClient which caused a panic later on.

Fixes #45298

Changelog: Prevents a panic caused by AWS STS client not being initialized when assuming an AWS Role

When assuming a role, we didn't properly init `a.stsClient` which caused a panic later on.

Fixes #45298

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
@tigrato tigrato force-pushed the tigrato/fix-kube-panic branch from 34aafe4 to d15f36d Compare August 9, 2024 09:05
@tigrato tigrato requested a review from GavinFrazar August 9, 2024 09:06
@tigrato tigrato enabled auto-merge August 12, 2024 13:31
@tigrato tigrato added this pull request to the merge queue Aug 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@tigrato tigrato added this pull request to the merge queue Aug 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 12, 2024
When assuming a role, we didn't properly init `a.stsClient` which caused a panic later on.

Fixes #45298

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@tigrato tigrato added this pull request to the merge queue Aug 12, 2024
Merged via the queue into master with commit ef4cc0d Aug 12, 2024
35 checks passed
@tigrato tigrato deleted the tigrato/fix-kube-panic branch August 12, 2024 15:42
@public-teleport-github-review-bot

@tigrato See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discovery_service panics when EKS matcher uses assume_role_arn
3 participants