[v16] Update resolving SSH hosts to use unified API #45644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new GetAllUnifiedResources function was added to replace GetAllResources so that ssh host resolution during tsh ssh used the more performant API. Additionally, the fallback clientside filtering in GetSSHTargets that used GetAllResources was removed as all supported auth instances should implement the GetSSHTargets RPC.
zmb3
approved these changes
Aug 20, 2024
marcoandredinis
approved these changes
Aug 21, 2024
public-teleport-github-review-bot
bot
removed the request for review
from nklaassen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #45626 to branch/v16
changelog: Improve performance of host resolution performed via tsh ssh when connecting via labels or proxy templates.