[v16] Allow changing terminal shell in Teleport Connect #45734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Get available shells for the system and store them in `RuntimeSettings` * Add a config option for `terminal.shell` * Add `shellId` to terminal documents and pty commands * Pass the `shellId` from pty command to pty process options (and resolve it to the shell path) * Allow changing the active and default shell from the context menu * Show active shell in the tab name, drop "Terminal" from the name on Windows * Fix resolving shell env for `csh` * Do not read unix shells from `/etc/shells`, add a config property for the custom shell * Add a whitelist of config properties that can be modified from the renderer * Allow selecting custom shell * Return back the actually opened shell and creation status * Pass variables to WSL via WSLENV * Do not change the default shell when selecting a custom shell * Show profile switcher only when there is more than one shell to choose from * Show shell name in the "Default Shell" context menu as sublabel * Remove comment about sync setup of `setUpDeepLinks` * Replace `MainTabContextMenuOptions` type * Improve types in `subscribeToTabContextMenuEvent` * Use early return * Fix condition in the schema for `terminal.shell` * Expand the comment for `preventAutoPromiseResolveOnMenuClose` * Render available shells without an array * `openedShell` -> `shell` * Add tests for resolving shell * Remove `PtyOptions` * Preserve user defined WSLENV * Remove the check for `fs.access(customShellPath)` * Mock `process.env` instead of mutating it * Fix remaining `openedShell` -> `shell` * Fix `PATH` issue on Windows * Remove updating a document with the default shell in `useDocumentTerminal` * Add `canDocChangeShell` * Omit the default shell name on Linux too * Convert `buildPtyOptions` parameters to object, pass `process.env` from above * Revert "Remove updating a document with the default shell in `useDocumentTerminal`" This reverts commit 52f0485. * Improve comments * Throw when the document doesn't exist (cherry picked from commit 806dcda)
ravicious
approved these changes
Aug 23, 2024
avatus
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #45152 to branch/v16
changelog: The terminal shell can now be changed in Teleport Connect by right-clicking on a terminal tab. This allows using WSL (
wsl.exe) if it is installed. Also, the default shell on Windows has been changed topwsh.exe(instead ofpowershell.exe).