desktop access: improve error handling when directory sharing fails #45808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If drive redirection is disabled on the Windows side, then directory sharing will fail even if Teleport RBAC allows it. Prior to this change failure to share a directory was considered a fatal error that would terminate the session. This change updates the error message and makes the error a warning so that the session remains alive even if the directory sharing operation fails.
rosstimothy
approved these changes
Aug 25, 2024
bl-nero
approved these changes
Aug 26, 2024
public-teleport-github-review-bot
bot
removed request for
probakowski,
kiosion and
kimlisa
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If drive redirection is disabled on the Windows side, then directory sharing will fail even if Teleport RBAC allows it. Prior to this change failure to share a directory was considered a fatal error that would terminate the session.
This change updates the error message and makes the error a warning so that the session remains alive even if the directory sharing operation fails.
changelog: Failure to share a local directory in a Windows desktop session is no longer considered a fatal error.
Before:
After: