Add static host user tests #47051
Merged
Add static host user tests #47051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atburke
added
no-changelog
rosstimothy
approved these changes
Oct 1, 2024
espadolini
approved these changes
Oct 2, 2024
lib/srv/statichostusers.go
Outdated
| @@ -142,7 +151,7 @@ func (s *StaticHostUserHandler) run(ctx context.Context) error { | |||
| return trace.Errorf("missing init event from watcher") | |||
| } | |||
| s.retry.Reset() | |||
| case <-time.After(staticHostUserWatcherTimeout): | |||
| case <-s.clock.After(staticHostUserWatcherTimeout): | |||
There was a problem hiding this comment.
This should probably be a timer that we explicitly stop if it's using a clockwork.Clock.
public-teleport-github-review-bot
bot
removed the request for review
from Tener
atburke
force-pushed
the
atburke/static-user-tests
branch
from
325c6bb to
c0678aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds test coverage for the static host user handler in
lib/srv/statichostuser.go.Part of #42712.