Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] display all security group rules for a port range #47077

Conversation

GavinFrazar
Copy link
Contributor

Changelog: Fixed a bug where only one IP CIDR block security group rule for a port range was displayed in the web UI RDS enrollment wizard when viewing a security group.

Backport #47009 to branch/v16.

there was a straightforward merge conflict with a <Text> on v16 vs <H2> in master - I kept the content of the html tag the same as the backported PR but left it as a <Text>. Relevant snippet was:

        <Text mb={4} typography="h4">
          {ruleType === 'inbound' ? 'Inbound' : 'Outbound'} Rules for [{name}]
        </Text>

@GavinFrazar GavinFrazar added ui backport discover Issues related to Teleport Discover labels Oct 2, 2024
@github-actions github-actions bot requested a review from avatus October 2, 2024 02:15
@github-actions github-actions bot requested a review from kimlisa October 2, 2024 02:15
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from avatus October 2, 2024 18:46
@GavinFrazar GavinFrazar added this pull request to the merge queue Oct 2, 2024
Merged via the queue into branch/v16 with commit c8af2a7 Oct 2, 2024
41 of 42 checks passed
@GavinFrazar GavinFrazar deleted the gavinfrazar/v16-display-all-security-group-rules-per-port branch October 2, 2024 21:04
@camscale camscale mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport discover Issues related to Teleport Discover size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants