[secscanner] close stream after each report #47143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
added
no-changelog
tigrato
force-pushed
the
tigrato/fix-stream-close
branch
3 times, most recently
from
5977162 to
c38d760
Compare
r0mant
approved these changes
Oct 3, 2024
ryanclark
approved these changes
Oct 3, 2024
public-teleport-github-review-bot
bot
removed the request for review
from bernardjkim
marcoandredinis
approved these changes
Oct 3, 2024
tigrato
force-pushed
the
tigrato/fix-stream-close
branch
from
c38d760 to
c8a37b6
Compare
This PR closes the client stream after each successfull report so we do not end up with streams that were closed and couldn't recover. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/fix-stream-close
branch
from
c8a37b6 to
0992ace
Compare
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes the client stream after each successfull report so we do not end up with streams that were closed and couldn't recover.