Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bastion machine type to variable in AWS HA terraform #47297

Merged
merged 5 commits into from
Oct 8, 2024
Merged

update bastion machine type to variable in AWS HA terraform #47297

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e2159b
update bastion machine type to variable in AWS HA terraform
stevenGravy Oct 7, 2024
fafda7f
Include instance type variables in README and Makefile for AWS HA ter…
stevenGravy Oct 7, 2024
91eb349
update comments and spacing for aws ha terraform
stevenGravy Oct 8, 2024
6e28827
Merge branch 'master' into stevenGravy/awshaterraform
stevenGravy Oct 8, 2024
9dcd620
fix variable assignment for Makefile,README in aws ha terraform
stevenGravy Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/aws/terraform/ha-autoscale-cluster/bastion.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
resource "aws_instance" "bastion" {
count = "1"
ami = data.aws_ami.base.id
instance_type = "t4g.medium"
instance_type = var.bastion_instance_type
key_name = var.key_name
associate_public_ip_address = true
source_dest_check = false
Expand Down
6 changes: 6 additions & 0 deletions examples/aws/terraform/ha-autoscale-cluster/vars.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ variable "node_instance_type" {
default = "t4g.medium"
}

// Instance type used for bastion server
variable "bastion_instance_type" {
type = string
default = "t4g.medium"
stevenGravy marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of having a more "friendly" experience for new users, maybe we could default this to null, then conditionally set the instance type deployed based off of the AMI architecture from data.aws_ami.base?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this idea, but think it's probably better implemented in a future PR as it'll require a fair bit more testing.

}

// SSH key name to provision instances withx
variable "key_name" {
type = string
Expand Down
Loading