Improve error messaging when connections to nodes fail #47351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents duplicate information about missing tunnels preventing a connection when attempting to connect locally and via a proxy peer. The error from the remote dial is now omitted from the message provided to end users. The information about how the connection was attempted was instead updated to reflect that tunnels were attempted via both the local proxy and a peer and they both failed. Additionally, if a hostname was provided in the dial request, it will be included in the error message instead of the internal @local-node identifier for tunnels or the public address for direct dial nodes. Closes #45256.
|
See the below screenshots for what the error messaging now looks like on this branch in various connection scenarios: Failure to connect to a tunnel node when proxy peering is enabled Failure to connect to a tunnel node when proxy peering is disabled: Failure to connect to a direct dial node: |
fspmarshall
approved these changes
Oct 8, 2024
rosstimothy
changed the title
espadolini
approved these changes
Oct 8, 2024
public-teleport-github-review-bot
bot
removed the request for review
from Tener
|
@rosstimothy See the table below for backport results.
|
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents duplicate information about missing tunnels preventing a connection when attempting to connect locally and via a proxy peer. The error from the remote dial is now omitted from the message provided to end users. The information about how the connection was attempted was instead updated to reflect that tunnels were attempted via both the local proxy and a peer and they both failed. Additionally, if a hostname was provided in the dial request, it will be included in the error message instead of the internal @local-node identifier for tunnels or the public address for direct dial nodes.
Closes #45256.
changelog: Improve error messaging when connections to offline agents are attempted